[FIX] owcsvimport: Fix a type error in _open for zip archive#4921
Merged
janezd merged 2 commits intobiolab:masterfrom Jul 30, 2020
Merged
[FIX] owcsvimport: Fix a type error in _open for zip archive#4921janezd merged 2 commits intobiolab:masterfrom
janezd merged 2 commits intobiolab:masterfrom
Conversation
ales-erjavec
force-pushed
the
fixes/owcsvimport-open-zip
branch
from
e4ca65f to
73b9048
Compare
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
==========================================
+ Coverage 84.10% 84.12% +0.02%
==========================================
Files 278 278
Lines 56994 56999 +5
==========================================
+ Hits 47934 47951 +17
+ Misses 9060 9048 -12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
CSVFileImport intends to but fails to read single member zip archive (raises a TypeError).
(e.g precip.csv.zip)
Description of changes
Fix a type error.
Includes